chore: align DATA_API_BUILDER_VERSION_ID with manifest latest (#969)#992
Closed
LongOddCode wants to merge 1 commit intoAzure:mainfrom
Closed
chore: align DATA_API_BUILDER_VERSION_ID with manifest latest (#969)#992LongOddCode wants to merge 1 commit intoAzure:mainfrom
LongOddCode wants to merge 1 commit intoAzure:mainfrom
Conversation
) The constant was pinned to 0.5.32 while the metadata manifest (linkid=2226493) has advanced to 1.3.19 as the current 'released' latest. The constant is currently only referenced in a commented-out line in dab.ts (version-pin fallback), so this change is documentation-oriented: it aligns the default identifier in source with the manifest so readers are not misled about the shipped version.
Contributor
|
Our feature on database connection is deprecated. So DATA_API_BUILDER is not needed. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #969 reports that
DATA_API_BUILDER_VERSION_IDinsrc/core/constants.tswas pinned to0.5.32, while the upstream DAB release-metadata manifest has since advanced well beyond that value. The mismatch is misleading for contributors reading the source — the manifest already serves a newerlatest, but the constant suggests the CLI is still on the legacy 0.5.x line.Verified live manifest state (2026-04-21):
{ "version": "latest", "versionId": "1.3.19", "releaseType": "released", "releaseDate": "2024-11-29" }Root Cause
The constant is a static pin that has not been updated alongside DAB releases. It is referenced only by a commented-out line in
src/core/dataApiBuilder/dab.tsintended for optional version pinning — runtime behavior is driven by the manifest'slatestentry, not by this constant. So the value has drifted without functional impact.Fix
src/core/constants.tsDATA_API_BUILDER_VERSION_ID0.5.32→1.3.191.3.19matches thelatestentry currently served by the DAB fwlink manifest. A subsequent bump to 1.5.x / 1.7.x can be done once the DAB team promotes a newer build tolatestin the manifest (the issue author also suggests coordinating with the DAB team for timely updates).Testing
git diffshows single-line change in constants.DATA_API_BUILDER_VERSION_IDat runtime (grep confirms only a commented-out usage indab.ts); no behavior change.latest.versionId.References